Date: Sat, 24 Nov 2007 20:50:51 +0100 From: "Attilio Rao" <attilio@freebsd.org> To: "Robert Watson" <rwatson@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_lock.c src/sys/sys lockmgr.h Message-ID: <3bbf2fe10711241150y332a202s17d38f05c2c785df@mail.gmail.com> In-Reply-To: <20071124194615.Y14018@fledge.watson.org> References: <200711240422.lAO4MSGT071285@repoman.freebsd.org> <20071124194615.Y14018@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2007/11/24, Robert Watson <rwatson@freebsd.org>: > On Sat, 24 Nov 2007, Attilio Rao wrote: > > > attilio 2007-11-24 04:22:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_lock.c > > sys/sys lockmgr.h > > Log: > > transferlockers() is a very dangerous and hack-ish function as waiters > > should never be moved by one lock to another. > > As, luckily, nothing in our tree is using it, axe the function. > > > > This breaks lockmgr KPI, so interested, third-party modules should update > > their source code with appropriate replacement. > > > > Ok'ed by: ups, rwatson > > "Ok'd by" doesn't generally seem to be a convention for FreeBSD commit > messages--I'd suggest "discussed with" which makes it seem a bit less like > approval, which is generally captured with "approved by". Though I saw it used several time, ok, thanks. Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10711241150y332a202s17d38f05c2c785df>