Date: Sat, 08 Apr 2006 17:43:06 -0600 From: Scott Long <scottl@samsco.org> To: Nate Lawson <nate@root.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Paul Saab <ps@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/amr amr.c amr_pci.c amrvar.h Message-ID: <44384A8A.6000609@samsco.org> In-Reply-To: <4438444E.7040009@root.org> References: <20060408022346.A583C16A4E4@hub.freebsd.org> <4438444E.7040009@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson wrote: > Paul Saab wrote: > >> ps 2006-04-08 02:23:27 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/amr amr.c amr_pci.c amrvar.h Log: >> Close a pesky race where after checking the BUSY flag in >> amr_wait_command, >> the completion of the command can occur before tsleep is called and >> the command ends up blocking forever since the wakeup has already >> been called. >> Submitted by: ups >> Revision Changes Path >> 1.76 +19 -6 src/sys/dev/amr/amr.c >> 1.35 +1 -0 src/sys/dev/amr/amr_pci.c >> 1.31 +1 -0 src/sys/dev/amr/amrvar.h > > > This would be a good audit task to do on the whole kernel. There are > very few legitimate uses of tsleep() these days. > There are legitimate uses, this just isn't one of them. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44384A8A.6000609>