Date: Mon, 17 Jun 2019 10:46:54 -0700 From: Warner Losh <imp@bsdimp.com> To: Scott Long <scottl@samsco.org> Cc: Niclas Zeising <zeising@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349146 - head/share/man/man4 Message-ID: <CANCZdfoYGWf_7Cpovo7Eb7zZCsCF6X=DtqQccKoN9rDwBkQdew@mail.gmail.com> In-Reply-To: <223A02B4-20E2-4973-B3E1-9E5D8E1B0D20@samsco.org> References: <201906171654.x5HGsqQm003736@repo.freebsd.org> <223A02B4-20E2-4973-B3E1-9E5D8E1B0D20@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Especially since there can be multiple PCI registers that can be read in 1 32-bit transaction. Warner On Mon, Jun 17, 2019, 10:28 AM Scott Long <scottl@samsco.org> wrote: > It=E2=80=99s customary to refer to PCI configuration registers in the plu= ral > form. Would > you mind changing back from =E2=80=9Cregister=E2=80=9D to =E2=80=9Cregist= ers=E2=80=9D? > > Thanks, > Scott > > > > On Jun 17, 2019, at 10:54 AM, Niclas Zeising <zeising@FreeBSD.org> > wrote: > > > > Author: zeising (doc,ports committer) > > Date: Mon Jun 17 16:54:51 2019 > > New Revision: 349146 > > URL: https://svnweb.freebsd.org/changeset/base/349146 > > > > Log: > > pci.4: wordsmith and add missing words > > > > Add missing words after PCI in the description of the PCIOCWRITE and > > PCIOCATTACHED ioctls. > > Use singular in PCIOCREAD, we only read one register at the time. > > > > Reviewed by: bcr, bjk, rgrimes, cem > > MFC after: 2 weeks > > X-MFC-with: r349133 > > Differential Revision: https://reviews.freebsd.org/D20671 > > > > Modified: > > head/share/man/man4/pci.4 > > > > Modified: head/share/man/man4/pci.4 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/share/man/man4/pci.4 Mon Jun 17 16:50:58 2019 (r349145) > > +++ head/share/man/man4/pci.4 Mon Jun 17 16:54:51 2019 (r349146) > > @@ -290,7 +290,7 @@ This > > .Xr ioctl 2 > > reads the > > .Tn PCI > > -configuration registers specified by the passed-in > > +configuration register specified by the passed-in > > .Va pci_io > > structure. > > The > > @@ -323,7 +323,7 @@ This > > .Xr ioctl 2 > > allows users to write to the > > .Tn PCI > > -specified in the passed-in > > +configuration register specified in the passed-in > > .Va pci_io > > structure. > > The > > @@ -338,7 +338,7 @@ This > > .Xr ioctl 2 > > allows users to query if a driver is attached to the > > .Tn PCI > > -specified in the passed-in > > +device specified in the passed-in > > .Va pci_io > > structure. > > The > > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoYGWf_7Cpovo7Eb7zZCsCF6X=DtqQccKoN9rDwBkQdew>