Date: Sun, 03 Mar 2019 13:42:06 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Ian Lepore <ian@freebsd.org> Cc: Enji Cooper <yaneurabeya@gmail.com>, Steven Hartland <steven@multiplay.co.uk>, Alexey Dokuchaev <danfe@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344701 - head/sbin/camcontrol Message-ID: <201903032142.x23Lg6Xf087501@slippy.cwsent.com> In-Reply-To: Message from Ian Lepore <ian@freebsd.org> of "Sun, 03 Mar 2019 13:28:41 -0700." <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> , Ian Le pore writes: > On Sun, 2019-03-03 at 12:20 -0800, Enji Cooper wrote: > > > On Mar 3, 2019, at 11:12, Steven Hartland <steven@multiplay.co.uk> > > > wrote: > > > > > > Not really much more to say that isn't explained by that and the > > > code. > > > > > > Sure I could have used a different sentence structure for the body > > > but it wouldn't add anything IMO, thoughts? > > > > Why the previous sector size was wrong isn’t clear from the > > commit message. Why switch from a sizeof to 0? > > Cheers! > > -Enji > > > > The commit message said it was "incorrect / unused". While a bit terse, > it does communicate that the old value was incorrect (by being there at > all) because the value is unused (so zero more clearly expresses that). > > It's not completely a joke that most English-speaking software > engineers have English as a second language. :) This is one of those profound quotes that should be in fortune(1). -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903032142.x23Lg6Xf087501>