Date: Sun, 26 Jun 2016 13:52:18 -0500 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Jens Schweikhardt <schweikh@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Jan Beich <jbeich@vfemail.net>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r298537 - head/etc/rc.d Message-ID: <CAJ5_RoCHH1inuwftzPw5AsUGG1B2j90WDrB_i8wJ4miO%2Bc3QFA@mail.gmail.com> In-Reply-To: <oa8z-54c1-wny@vfemail.net> References: <201604241053.u3OAr0bn072180@repo.freebsd.org> <oa8z-54c1-wny@vfemail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 24, 2016 at 12:01 PM, Jan Beich <jbeich@vfemail.net> wrote:
> Jens Schweikhardt <schweikh@FreeBSD.org> writes:
>
> > - parenthesize the "case" string for symmetry and improved
> > search for matching paren (e.g. with vi's %)
> [...]
> > case "${state}" in
> > - [oO][nN])
> > + ([oO][nN])
> > swapon /dev/zvol/${name}
> > ;;
>
> For style consistency is more important. Why this case is special unlike
> the rest of rc.d/* or rc.subr ?
>
Coming in quite late, I agree. I think this part should be reverted.
-Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoCHH1inuwftzPw5AsUGG1B2j90WDrB_i8wJ4miO%2Bc3QFA>