Date: Tue, 23 Nov 2021 15:03:15 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Olivier Cochard <olivier@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 50119a0b4317 - main - net-im/telegram-desktop: Cleanup and set new maintainer Message-ID: <YZ0CsxJ7e4delAAU@FreeBSD.org> In-Reply-To: <YZWzbDPane3tw%2Bjd@FreeBSD.org> References: <202111171708.1AHH81SP093799@gitrepo.freebsd.org> <YZWzbDPane3tw%2Bjd@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ping?
On Thu, Nov 18, 2021 at 01:59:08AM +0000, Alexey Dokuchaev wrote:
> On Wed, Nov 17, 2021 at 05:08:01PM +0000, Olivier Cochard wrote:
> > commit 50119a0b431718d00a22f424a550239246021ff9
> >
> > net-im/telegram-desktop: Cleanup and set new maintainer
> >
> > Reported by: glebius
>
> Sorry, I don't understand, what exactly was "reported" here? This
> looks more like a patch submission committed without maintainer
> approval.
>
> > -CMAKE_OFF= DESKTOP_APP_USE_PACKAGED_RLOTTIE DESKTOP_APP_USE_PACKAGED_VARIANT \
> > - DESKTOP_APP_USE_GLIBC_WRAPS TDESKTOP_USE_PACKAGED_TGVOIP \
> > - DESKTOP_APP_USE_PACKAGED_FONTS
> > +CMAKE_OFF= DESKTOP_APP_USE_PACKAGED_FONTS
>
> These vars being dropped from CMAKE_OFF should've been explained.
>
> > +INSTALLS_ICONS= yes
> > +
>
> Please see the latest CHANGES entry 20211010.
>
> > -.if ${CHOSEN_COMPILER_TYPE} == clang && ${COMPILER_VERSION} <= 100
> > -post-patch:
> > - @${REINPLACE_CMD} -e '/-fstack-clash-protection/d' ${WRKSRC}/cmake/options_linux.cmake
> > +.if ${COMPILER_VERSION} < 120
> > +LLVM_VER= 12
> > +BUILD_DEPENDS+= clang${LLVM_VER}:devel/llvm${LLVM_VER}
> > +CC= ${LOCALBASE}/bin/clang${LLVM_VER}
> > +CXX= ${LOCALBASE}/bin/clang++${LLVM_VER}
>
> Pulling in non-default LLVM port is hardly a "cleanup" and also deserves
> a proper explanation; so does removing those patches.
>
> ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YZ0CsxJ7e4delAAU>