Date: Thu, 3 May 2007 11:31:10 +0800 From: "Rong-en Fan" <grafan@gmail.com> To: "Colin Percival" <cperciva@freebsd.org>, kientzle@freebsd.org, portmgr@freebsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/tar write.c Message-ID: <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> In-Reply-To: <200703151011.l2FABc9Z013002@repoman.freebsd.org> References: <200703151011.l2FABc9Z013002@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/15/07, Colin Percival <cperciva@freebsd.org> wrote: > cperciva 2007-03-15 10:11:38 UTC > > FreeBSD src repository > > Modified files: > usr.bin/tar write.c > Log: > Don't consider an lstat(2) failure to be an error (in the sense of > affecting the return value from bsdtar), since (a) it usually occurs > due to a perfectly innocent (and unavoidable) race condition where a > user deletes a file in the window between bsdtar reading a directory > and attempting to read the file; and (b) aside from printing a warning > message, bsdtar behaves exactly as if the file had been deleted prior > to bsdtar reading its parent directory. This commit makes 'make package' successfully even if the plist is wrong, i.e. it contains ``ghost'' files. Basically, $ tar zcvf a.tgz /aaa tar: /aaa: Cannot stat: No such file or directory It returns 0, so make package will be considered successful. That's why I only get chinese/CJK build failure on 5.x (this is merged to 6.x). I'm CC'ing kientzle@ and portmgr@ (since it affects our package building). Regards, Rong-En Fan. > > Reviewed by: kientzle > MFC after: 6 days > > Revision Changes Path > 1.57 +0 -1 src/usr.bin/tar/write.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6eb82e0705022031g3b959688k5fb63b6e441a6d86>