Date: Wed, 04 Jul 2007 17:16:37 +0200
From: Michal Mertl <mime@traveller.cz>
To: "Sean C. Farley" <scf@FreeBSD.org>
Cc: Andrey Chernov <ache@nagual.pp.ru>, freebsd-current <freebsd-current@FreeBSD.org>
Subject: Re: Environment handling broken in /bin/sh with changes to {get,set,put}env()
Message-ID: <1183562197.1799.23.camel@genius.i.cz>
In-Reply-To: <20070704101026.O77978@thor.farley.org>
References: <1183557221.1799.16.camel@genius.i.cz> <20070704143642.GA31254@nagual.pp.ru> <20070704150312.GB31683@nagual.pp.ru> <20070704101026.O77978@thor.farley.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sean C. Farley wrote: > On Wed, 4 Jul 2007, Andrey Chernov wrote: > > > On Wed, Jul 04, 2007 at 06:36:42PM +0400, Andrey Chernov wrote: > >> 2) "s" may point to getenv()-provided value there. So just modifying > >> it directly followed by setenv() call will make things inconsistent. > >> > >> 3) In my version of patch there was savestr() which copy arg to avoid > >> this situation. > >> > >> Fix will be to restore var.c to mine variant 1.34 > > > > You may also try this patch against var.c 1.36: > > Andrey, thank you. > > Sorry for the bug everyone. Here is a patch that should fix it: > http://www.farley.org/freebsd/tmp/setenv/sh.patch > > Sean Both version of a patch fix the regression, thanks. Michal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1183562197.1799.23.camel>