Date: Tue, 4 Feb 2025 16:21:26 -0500 From: Ed Maste <emaste@freebsd.org> To: Rick Macklem <rick.macklem@gmail.com> Cc: Cy Schubert <Cy.Schubert@cschubert.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ecccb638d494 - main - mountd: Promote missing netmask log to LOG_ERR Message-ID: <CAPyFy2DkBgnkiZgoh59NERPsLsrupkijJ4oLOs-bL2-f3hpodA@mail.gmail.com> In-Reply-To: <CAM5tNy4v_7yLFLi0k_iv_MOJvgaMaghMULd28PhOcOLnpxphoA@mail.gmail.com> References: <202502041658.514Gwo4I049201@gitrepo.freebsd.org> <20250204171121.8EA2C281@slippy.cwsent.com> <CAM5tNy4v_7yLFLi0k_iv_MOJvgaMaghMULd28PhOcOLnpxphoA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > Should this be changed from WARNING to ERROR too? > I don't have a strong opinion, but I would say no. > An error in mountd indicates a failure and in this case the semantics > remain what they have always been and doesn't necessarily imply > a semantics failure. I agree with Rick. I wasn't sure about this at first, but noticed that there are some "Warning:" syslogs at LOG_ERR priority already.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2DkBgnkiZgoh59NERPsLsrupkijJ4oLOs-bL2-f3hpodA>