Date: Mon, 1 Aug 2005 21:23:27 +0700 From: Max Khon <fjoe@samodelkin.net> To: Alexander Leidinger <netchild@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_hints.c Message-ID: <20050801142327.GA71555@samodelkin.net> In-Reply-To: <200507311046.j6VAktvC055088@repoman.freebsd.org> References: <200507311046.j6VAktvC055088@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! On Sun, Jul 31, 2005 at 10:46:55AM +0000, Alexander Leidinger wrote: > netchild 2005-07-31 10:46:55 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_hints.c > Log: > The resource_xxx routines in subr_hints.c are called before and after the > kenv environment in kern_environment.c switches to dynamic kenv. The prior > call sets the static variable hintp to the static hints in subr_hints.c > (hintmode==0). > > However, changes to the environment are not detected by the resource_xxx > lookups after the change to dynamic kernel environment, so the lookup > routines only report the old stuff of hintmode==0, even after the change to > the dynamic kenv. This causes kenv users to see a different environment than > the kernel routines. > > This is a problem in the mixer.c code that looks up initial mixer volume > settings from the hints: If the hints are dynamic and not from the > device.hints file, mixer.c doesn't see them, but kenv does. > > The patch from the PR (modified to comply to the style of the function) > solves this. > > PR: 83686 > Submitted by: Harry Coin <harrycoin@qconline.com> > > Revision Changes Path > 1.12 +2 -0 src/sys/kern/subr_hints.c Do you plan to MFC this to RELENG_6? /fjoe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050801142327.GA71555>