Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Aug 2009 11:59:30 +0400
From:      Dmitry Sivachenko <demon@freebsd.org>
To:        Pyun YongHyeon <pyunyh@gmail.com>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, David Christensen <davidch@freebsd.org>, Stanislav Sedov <stas@freebsd.org>, Tom Judge <tom@tomjudge.com>, svn-src-head@freebsd.org, Xin LI <delphij@delphij.net>
Subject:   Re: svn commit: r189117 - head/sys/dev/bce
Message-ID:  <20090825075930.GA77905@m4-new.master-telecom.ru>
In-Reply-To: <20090812225726.GI55129@michelle.cdnetworks.com>
References:  <200902271925.n1RJP699080658@svn.freebsd.org> <20090721145559.d2cf3f0b.stas@FreeBSD.org> <4A7AFFC4.5050607@tomjudge.com> <20090812234935.84e5ac74.stas@FreeBSD.org> <4A8337BD.3010700@delphij.net> <20090812225726.GI55129@michelle.cdnetworks.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 12, 2009 at 03:57:26PM -0700, Pyun YongHyeon wrote:
> On Wed, Aug 12, 2009 at 02:44:29PM -0700, Xin LI wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Hi, Stanislav,
> > 
> > Stanislav Sedov wrote:
> > > On Thu, 06 Aug 2009 11:07:32 -0500
> > > Tom Judge <tom@tomjudge.com> mentioned:
> > > 
> > >> I can confirm that we are also seeing this problem on a number of Dell 
> > >> PE2950 systems running the bce driver from 7.2, the bug is more 
> > >> visible/producible on systems that are using Jumbo Frames (in our case 8Kb).
> > >>
> > >> The symptoms of this are an increase in the requests for jumbo clusters 
> > >> denied counter at 9k, and then random network stalls which sometimes 
> > >> recover on there own and others require a reboot.
> > >>
> > >> We have backed this change and so far it seems to have fixed the issue.
> > >>
> > > 
> > > David,
> > > 
> > > are you OK with reverting this patch?  I submitted the patch to re@ for
> > > review, and I can commit it if you don't mind doing so. :-)
> > 
> > I think there was some motivation supporting the SPLIT_HEADER disable in
> > the past (IIRC it was for reliability or data corruption), but I think I
> > have lost the mail archive (at least I couldn't find it at this moment
> > :-/  I'm not very sure if that was fixed by my busdma_sync fix, though,
> > can anyone confirm that?
> > 
> 
> Since I don't have bce(4) hardwares I can't confirm it. I think the
> busdma_sync fix would be prerequisite condition to fix data
> corruption problem but I think it would not necessarily fix
> previous data corruption issue.


I wish you reach some consensus there because bce(4) is indeed
broken and stas's patch seems to make it better.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090825075930.GA77905>