Date: Tue, 14 Jun 2005 14:22:27 +0800 From: Xin LI <delphij@delphij.net> To: Peter Wemm <peter@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/syscons scgfbrndr.c scvgarndr.c Message-ID: <1118730147.733.6.camel@spirit> In-Reply-To: <200506140243.j5E2hjnh044694@repoman.freebsd.org> References: <200506140243.j5E2hjnh044694@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > peter 2005-06-14 02:43:45 UTC > > FreeBSD src repository > > Modified files: > sys/dev/syscons scgfbrndr.c scvgarndr.c > Log: > Fix syscons on amd64. The SC_PIXEL_MODE commit from May 29th added a new > function pointer to the vga render dispatch table and initialized it with > vga_nop. The problem is that vga_nop() is a varargs function, and the > table declares a non-varargs function pointer. On amd64 (and I think ppc), > mixing varargs and non-varargs function pointers is fatal. > > Change vga_nop() and gfb_nop() from varargs to non-varargs do-nothing > functions. This stops the stack corruption that only happened on amd64. Thanks! -- Xin LI <delphij delphij net> http://www.delphij.net/ [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBCrnej/cVsHxFZiIoRAtcqAJ9sVvTLMQ4YbqDmC27TnZ6puxax7gCdHTJe uhws6ajrGLQW7swzLiQ0mdA= =RDeL -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1118730147.733.6.camel>