Date: Mon, 13 Sep 2004 07:10:31 GMT From: Dan Lukes <dan@obluda.cz> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/71628: [PATCH] cleanup of the usr.sbin/rpcbind code Message-ID: <200409130710.i8D7AVs6023642@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/71628; it has been noted by GNATS. From: Dan Lukes <dan@obluda.cz> To: Giorgos Keramidas <keramida@freebsd.org> Cc: Dima Dorfman <dd@freebsd.org>, bug-followup@freebsd.org Subject: Re: bin/71628: [PATCH] cleanup of the usr.sbin/rpcbind code Date: Mon, 13 Sep 2004 09:02:41 +0200 Giorgos Keramidas wrote: > That's a different thing. Not using a variable isn't really dangerous. > Using the value of a pointer whose initial value contains garbage *is* > dangerous. Unless you accidentally use "len" instead of "slen" which is totally diferent variable. Even "declared but newer used" warning may warn agains dangerous error within the code. It's the reason why any warning should be carefully evaluated (it's the reason we should eliminate warnings to already evaluated code) > I think a lot of the work in these patches is useful. A few changes > here, a minor fix there and it'll be nice if they're committed and have > as many warnings fixed as possible. This is my personal opinion though. Well, I hope somebody commit it. > Keep up the good work ;-) Thanks. And thanks for suggestions also. Dan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409130710.i8D7AVs6023642>