Date: Thu, 03 Dec 2009 18:28:30 +0200 From: Alexander Motin <mav@FreeBSD.org> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 171334 for review Message-ID: <4B17E72E.5010304@FreeBSD.org> In-Reply-To: <4B17DFEA.1020704@freebsd.org> References: <200912031546.nB3Fksxc047234@repoman.freebsd.org> <4B17DFEA.1020704@freebsd.org>
index | next in thread | previous in thread | raw e-mail
Nathan Whitehorn wrote: > Alexander Motin wrote: >> @@ -230,7 +229,7 @@ >> return EIO; >> } >> >> - request->dma = &ch->dma.slot[atadev->unit]; >> + request->dma = &ch->dma.slot[0]; >> >> if ((error = bus_dmamap_load(request->dma->data_tag, >> request->dma->data_map, request->data, request->bytecount, >> > I made an error in this part of the patch -- it should be request->unit, > not 0, here. Thanks for your work! It's not your fault, it's my change. It shouldn't be request->unit there, as only one DMA slot per channel allocated now. It is useless to allocate more, as rest of ata(4) infrastructure supports only one request at a time per channel. -- Alexander Motinhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B17E72E.5010304>