Date: Sat, 3 Nov 2012 23:28:44 -0700 From: Julian Main <julian@elischer.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Anuranjan Shukla <anshukla@juniper.net> Subject: Re: Proposal for changes to network device drivers and network stack (RFC) Message-ID: <24AEFB78-C46F-4837-81E1-01250CA8666E@elischer.org> In-Reply-To: <3465231B-CEC2-4FC1-92EF-95C535EFCBED@xcllnt.net> References: <CC5C760E.18207%anshukla@juniper.net> <570F1A37-38F0-41CF-91C7-B6047AA79E97@neville-neil.com> <3465231B-CEC2-4FC1-92EF-95C535EFCBED@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> > > I renamed the interface implementation from mumble_ddi.h to > if_device.[ch] and put a diff here: > http://people.freebsd.org/~marcel/Juniper/if_device.diff Looks reasonable to me. Gives some protection from API change But to really make use of this you could have driver specific methods... > > To see how it's used and/or how it changes a device driver, look > at a diff to if_em.c here: > http://people.freebsd.org/~marcel/Juniper/if_em.diff > > Some notes: > 1. Yes, there needs a license at the top. It's 2-clause BSD > 2. The function pointers are macros right now. I think it's > better to have an ops structure and a single function to > set the ops than a bunch of accessors to set functions. > 3. The code needs to be tidied up. > > What I'd like to see is a discussion on the functions themselves. > They're the result of looking at a single driver (or maybe 2 > drivers), and as such may not be perfectly generic or logical. > > As said before: we'd like to focus on an ABI-stable interface, > but a one based on macros should also be possible. > > Sorry for the delay, > > -- > Marcel Moolenaar > marcel@xcllnt.net > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?24AEFB78-C46F-4837-81E1-01250CA8666E>