Date: Wed, 19 Jan 2011 08:15:40 -0500 From: John Baldwin <jhb@freebsd.org> To: Peter Jeremy <peterjeremy@acm.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217538 - in head/sys/dev: buslogic cs Message-ID: <201101190815.40908.jhb@freebsd.org> In-Reply-To: <20110119055635.GA90983@server.vk2pj.dyndns.org> References: <201101181523.p0IFNGeB042079@svn.freebsd.org> <20110119055635.GA90983@server.vk2pj.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, January 19, 2011 12:56:35 am Peter Jeremy wrote:
> On 2011-Jan-18 15:23:16 +0000, John Baldwin <jhb@FreeBSD.org> wrote:
> >Log:
> > Remove some always-true comparisons.
> ...
> >--- head/sys/dev/cs/if_cs.c Tue Jan 18 14:58:44 2011 (r217537)
> >+++ head/sys/dev/cs/if_cs.c Tue Jan 18 15:23:16 2011 (r217538)
> >@@ -364,7 +364,7 @@ cs_cs89x0_probe(device_t dev)
> >
> > if (!error && !(sc->flags & CS_NO_IRQ)) {
> > if (chip_type == CS8900) {
> >- if (irq >= 0 || irq < 16)
> >+ if (irq < 16)
> > irq = cs8900_irq2eeint[irq];
> > else
> > irq = 255;
>
> Irrespective of the signedness or otherwise of "irq", I'm fairly
> certain that '||' should have been '&&' before.
Agreed.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101190815.40908.jhb>