Date: Tue, 20 Nov 2001 12:10:02 -0800 (PST) From: Mikhail Teterin <mi@aldan.algebra.com> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/32138: better progress reporting for dump(8) Message-ID: <200111202010.fAKKA2E04242@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/32138; it has been noted by GNATS.
From: Mikhail Teterin <mi@aldan.algebra.com>
To: iedowse@maths.tcd.ie
Cc: arr@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: bin/32138: better progress reporting for dump(8)
Date: Tue, 20 Nov 2001 15:06:20 -0500 (EST)
On 20 Nov, Ian Dowse wrote:
> In message <Pine.NEB.3.96L.1011120143005.92014C-100000@fledge.watson.org>,
> "Andrew R. Reiter" writes:
>>
>>setproctitle() should not even be used in the handler.
>
> Is it being called from a signal handler?
It is not. Not now, not in the original PR, not in the version last sent
to -arch (three weeks ago).
>You can avoid this side-effect by telling setproctitle not to print the
>last character, i.e:
> lastlen = strlen(lastmsg);
> if (lastlen > 0 && lastmsg[lastlen - 1] == '\n')
> lastlen--;
> setproctitle("%s: %.*s", disk, lastlen, lastmsg);
Yes! That's a good one... Thanks,
-mi
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111202010.fAKKA2E04242>