Date: Mon, 1 Apr 2002 16:33:55 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Matt Dillon <dillon@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alpha critical.c src/sys/alpha/include cpufunc.h ... Message-ID: <20020401163355.B38457@dragon.nuxi.com> In-Reply-To: <200204012351.g31NpO890339@freefall.freebsd.org>; from dillon@FreeBSD.org on Mon, Apr 01, 2002 at 03:51:24PM -0800 References: <200204012351.g31NpO890339@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 01, 2002 at 03:51:24PM -0800, Matt Dillon wrote: > Backout and re-apply improperly comitted syntactical cleanups made to files > that were still under active development. Backout improperly comitted program > structure changes that moved localized declarations to the top of two > procedures. Why are the "program structure changes that moved localized declarations to the top of two procedures", improper? > Note: In general, developers should not gratuitously move declarations out > of sub-blocks. They are where they are for reasons of structure, grouping, > readability, compiler-localizability, and to avoid developer-introduced bugs > similar to several found in recent years in the VFS and VM code. style(9) says otherwise -- code is more readable when all variables are declared at the top of a function. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020401163355.B38457>