Date: Tue, 10 Jun 2025 14:35:48 -0400 From: Kristof Provost <kp@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 948078b65c27 - main - pf: fix !VIMAGE build Message-ID: <6347B11C-FEEE-41C3-8A88-B79BE06C1CE0@FreeBSD.org> In-Reply-To: <202506100319.55A3JJr1086016@gitrepo.freebsd.org> References: <202506100319.55A3JJr1086016@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=_MailMate_ADE4FA85-C5E6-4EC9-8EAC-47829DBF6563_= Content-Type: text/plain; charset=UTF-8; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 9 Jun 2025, at 23:19, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D948078b65c275acfa55afe56a9bbd= eb2f61f1e2a > > commit 948078b65c275acfa55afe56a9bbdeb2f61f1e2a > Author: Gleb Smirnoff <glebius@FreeBSD.org> > AuthorDate: 2025-06-10 03:19:04 +0000 > Commit: Gleb Smirnoff <glebius@FreeBSD.org> > CommitDate: 2025-06-10 03:19:04 +0000 > > pf: fix !VIMAGE build Thanks for the fix. I was sure I=E2=80=99d done a make universe, but given the NOINET6 breaka= ge I = must be misremembering. Still, that wouldn=E2=80=99t have caught this one. It looks like we don=E2= =80=99t = have a single kernel config without VIMAGE left, and that makes it a bit = harder to detect this sort of breakage. I know that at least Netflix do care about that configuration, so I = think we should have a LINT-NOVIMAGE to make it at least a bit more = likely that we=E2=80=99ll detect such breakage before commits: = https://reviews.freebsd.org/D50780 =E2=80=94 Kristof --=_MailMate_ADE4FA85-C5E6-4EC9-8EAC-47829DBF6563_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/xhtml; charset=3Dutf-8"= > </head> <body><div style=3D"font-family: sans-serif;"><div class=3D"markdown" sty= le=3D"white-space: normal;"> <p dir=3D"auto">On 9 Jun 2025, at 23:19, Gleb Smirnoff wrote:</p> <blockquote style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px= solid #136BCE; color: #136BCE;"> <p dir=3D"auto">The branch main has been updated by glebius:</p> <p dir=3D"auto">URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D= 948078b65c275acfa55afe56a9bbdeb2f61f1e2a">https://cgit.FreeBSD.org/src/co= mmit/?id=3D948078b65c275acfa55afe56a9bbdeb2f61f1e2a</a></p> <p dir=3D"auto">commit 948078b65c275acfa55afe56a9bbdeb2f61f1e2a<br> Author: Gleb Smirnoff <a href=3D"mailto:glebius@FreeBSD.org">glebius@= FreeBSD.org</a><br> AuthorDate: 2025-06-10 03:19:04 +0000<br> Commit: Gleb Smirnoff <a href=3D"mailto:glebius@FreeBSD.org">glebius@= FreeBSD.org</a><br> CommitDate: 2025-06-10 03:19:04 +0000</p> <pre style=3D"margin-left: 15px; margin-right: 15px; padding: 5px; border= : thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #= E4E4E4;"><code style=3D"padding: 0 0.25em; background-color: #E4E4E4;">pf= : fix !VIMAGE build </code></pre> </blockquote> <p dir=3D"auto">Thanks for the fix.<br> I was sure I=E2=80=99d done a make universe, but given the NOINET6 breaka= ge I must be misremembering.</p> <p dir=3D"auto">Still, that wouldn=E2=80=99t have caught this one. It loo= ks like we don=E2=80=99t have a single kernel config without VIMAGE left,= and that makes it a bit harder to detect this sort of breakage.<br> I know that at least Netflix do care about that configuration, so I think= we should have a LINT-NOVIMAGE to make it at least a bit more likely tha= t we=E2=80=99ll detect such breakage before commits: <a href=3D"https://r= eviews.freebsd.org/D50780">https://reviews.freebsd.org/D50780</a></p>; <p dir=3D"auto">=E2=80=94<br> Kristof</p> </div> </div> </body> </html> --=_MailMate_ADE4FA85-C5E6-4EC9-8EAC-47829DBF6563_=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6347B11C-FEEE-41C3-8A88-B79BE06C1CE0>