Date: Mon, 9 Jan 2017 23:58:55 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Xin Li <delphij@delphij.net> Cc: Ngie Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, d@delphij.net, des@freebsd.org Subject: Re: svn commit: r311585 - in head: crypto/openssh secure/usr.sbin/sshd Message-ID: <18D51B59-6985-49FA-83E6-225B560053B5@gmail.com> In-Reply-To: <f8ca157b-9fc5-018e-7e66-5225e6301f25@delphij.net> References: <201701070808.v0788aEi064973@repo.freebsd.org> <f8ca157b-9fc5-018e-7e66-5225e6301f25@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 9, 2017, at 11:56 PM, Xin Li <delphij@delphij.net> wrote: >=20 >=20 > On 1/7/17 00:08, Ngie Cooper wrote: >> Author: ngie >> Date: Sat Jan 7 08:08:35 2017 >> New Revision: 311585 >> URL: https://svnweb.freebsd.org/changeset/base/311585 >>=20 >> Log: >> Conditionalize building libwrap support into sshd >>=20 >> Only build libwrap support into sshd if MK_TCP_WRAPPERS !=3D no >>=20 >> This will unbreak the build if libwrap has been removed from the = system >>=20 >> MFC after: 2 weeks >> PR: 210141 >> Submitted by: kpect@protonmail.com >> Differential Revision: D9049 >=20 > I didn't see this approved by maintainer, did you ping him? >=20 > [delphij@saturn] /usr/src> grep ssh MAINTAINERS > openssh des Pre-commit review requested. >=20 > (Not that the change itself is bad, though, but it's important to keep > everyone on the same page). I waited 3 days for a reply on the review: = https://reviews.freebsd.org/D9049 <https://reviews.freebsd.org/D9049>; . = Admittedly, it was a bit short of a timeout. -Ngie=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?18D51B59-6985-49FA-83E6-225B560053B5>