Date: Tue, 31 Mar 2015 10:09:33 -0700 From: hiren panchasara <hiren@strugglingcoder.info> To: Adrian Chadd <adrian@freebsd.org> Cc: Jack F Vogel <jfv@freebsd.org>, FreeBSD Net <freebsd-net@freebsd.org>, erj@freebsd.org, Jack Vogel <jfvogel@gmail.com>, Jason Wolfe <nitroboost@gmail.com> Subject: Re: Full 32bit flowid from igb(4) Message-ID: <20150331170933.GK10892@strugglingcoder.info> In-Reply-To: <CAJ-VmokL1PnA=Nv0wKTWtY2f1RLCzW3GShOPQ0t=gd6B93kC4A@mail.gmail.com> References: <20150323233908.GT53237@strugglingcoder.info> <20150323234214.GU53237@strugglingcoder.info> <CAFOYbc=f3OT85z50uqYEnBUkEej=8FRnRP8TpQuTStgqUEoDTA@mail.gmail.com> <20150324154931.GC53237@strugglingcoder.info> <CAJ-Vmo=ajfWokQ3bdu1Ww8kV3AdVwwsDpoS9y_%2Bywk%2BgcrbBvQ@mail.gmail.com> <20150330225945.GI10892@strugglingcoder.info> <CAJ-Vmom1tE6g=ta-DPLDF%2Bnp0GOpFYOXn=PkspaALfazz-n4Gg@mail.gmail.com> <20150331050628.GJ10892@strugglingcoder.info> <CAJ-VmokL1PnA=Nv0wKTWtY2f1RLCzW3GShOPQ0t=gd6B93kC4A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--IA03tywDYuoVKXrw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/30/15 at 10:53P, Adrian Chadd wrote: > No, you're absolutely right. However, you (a) get flowid for L3/L4 > V4/v6 but not other things, and (b) I was worried about changing the > default behaviour of the driver, and who knows what other weird crap > people may have done to their local driver. stuff like enabled > checksums instead, or hacked in flowtable support. :) >=20 > So, I'm totally fine if you want to populate the flowid for a given > flow. Totally okay. You just can't set it blindly - you can only set > it when the relevant descriptor bits say "it's a flowid!". Thanks for taking time and answering. Totally agree. Looking at the code, igb does setup everything correctly to get RSS hash in flowid when num_queues > 1. I'm not sure and I've not checked what other chipsets do but I350 looks fine. If needed I am okay to guard this with mac_type check. Jack/Eric: Let me know what you guys think. Cheers, Hiren --IA03tywDYuoVKXrw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVGtTNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lVUsH/0rQirWlljyzZkN+nlCO59hK NErW1lRJtq1b7ztWQjqWc3VDvCmYdoBAZksEPWm3nQoc6MgNYWLdNkm5zjbudbOh 8Q9+TSCberuS3RlZdM2eCppUuDtm68Uq6Zc8dTfjhWsZ6M5V5jwRMkhN9qRF7i0Y gVYA4eh0f0qyeIS0wc3wMi06ZjC6ve7zCSZk11i0knrX0kLAyEPyzilF1b+286IU nrcp0I55eLFy4X2cnTq/JWMWpjOf014468fhFS0VtPSF1wckTvlG3vvfz6LHRFMm LsAyai+mlTx05xIRrtFYA7LMwEepRnLVUM0WxlBEahMogsRFkzmhYXA5nSDg+zs= =wcC7 -----END PGP SIGNATURE----- --IA03tywDYuoVKXrw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150331170933.GK10892>