Date: Tue, 22 May 2001 19:07:44 -0700 From: Doug Barton <DougB@DougBarton.net> To: Robert Watson <rwatson@FreeBSD.org> Cc: Warner Losh <imp@harmony.village.org>, Matt Dillon <dillon@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_prot.c src/sys/sys ucred.h Message-ID: <3B0B1B70.CA534B97@DougBarton.net> References: <Pine.NEB.3.96L.1010517102638.18852A-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson wrote: > > On Thu, 17 May 2001, Warner Losh wrote: > > > In message <Pine.NEB.3.96L.1010517021401.8919E-100000@fledge.watson.org> Robert Watson writes: > > : Note that this may break binary compatibility for kernel modules that > > : relied on the existing crhold() macro. As such, this probably needs a > > : warning in UPDATING that modules must be recompiled, especially since this > > : is in -STABLE. > > > > You are right, but any idea if such modules exist? > > Hmm. Well, credential references are manipulated by at least the NFS and > SMBfs code, but I haven't really looked into much more detail. I haven't > figured out the byte order issues, but it may be this has different > effects on different platforms. I'd just give a general note of caution. > I think having the cr_ref updating in -STABLE is great, we just need to be > careful. Umm.... isn't this the kind of change we shouldn't do in -stable, especially if we're not sure whethere there are 3rd party modules that use it? Maybe I'm missing something here.... -- I need someone really bad. Are you really bad? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B0B1B70.CA534B97>