Date: Fri, 12 Oct 2012 08:55:30 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Kevin Lo <kevlo@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r241471 - head/share/man/man9 Message-ID: <20121012045530.GK89655@FreeBSD.org> In-Reply-To: <201210120131.q9C1V3jM018799@svn.freebsd.org> References: <201210120131.q9C1V3jM018799@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 12, 2012 at 01:31:03AM +0000, Kevin Lo wrote: K> Author: kevlo K> Date: Fri Oct 12 01:31:02 2012 K> New Revision: 241471 K> URL: http://svn.freebsd.org/changeset/base/241471 K> K> Log: K> Since the moduledata structure member priv is a void pointer, using K> NULL instead of 0 when dealing with pointers. K> K> Modified: K> head/share/man/man9/module.9 K> K> Modified: head/share/man/man9/module.9 K> ============================================================================== K> --- head/share/man/man9/module.9 Thu Oct 11 23:41:18 2012 (r241470) K> +++ head/share/man/man9/module.9 Fri Oct 12 01:31:02 2012 (r241471) K> @@ -99,7 +99,7 @@ static int foo_handler(module_t mod, int K> static moduledata_t mod_data= { K> "foo", K> foo_handler, K> - 0 K> + NULL K> }; K> K> MODULE_VERSION(foo, 1); I think we should provide C99 sparse initializers for structures in all manpages in section 9, as well as use only such initializers in any new code added to tree. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121012045530.GK89655>