Date: Thu, 17 Nov 2005 15:35:08 +0100 From: Stefan Farfeleder <stefanf@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Ariff Abdullah <ariff@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/sound/pcm channel.c Message-ID: <20051117143506.GL584@wombat.fafoe.narf.at> In-Reply-To: <20051117145139.h0rxsukk74wog4c8@netchild.homeip.net> References: <200511150419.jAF4JRUp080869@repoman.freebsd.org> <20051115105128.a5dd001i0ckock0s@netchild.homeip.net> <20051115095801.M61850@fledge.watson.org> <20051115202306.4cf2dcf2.ariff@FreeBSD.org> <20051115124331.GD9996@wombat.fafoe.narf.at> <20051117145139.h0rxsukk74wog4c8@netchild.homeip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 17, 2005 at 02:51:39PM +0100, Alexander Leidinger wrote: > Stefan Farfeleder <stefanf@FreeBSD.org> wrote: > > >On Tue, Nov 15, 2005 at 08:23:06PM +0800, Ariff Abdullah wrote: > >>On Tue, 15 Nov 2005 09:58:52 +0000 (GMT) > >>Robert Watson <rwatson@FreeBSD.org> wrote: > > >>> Probably a combination of -Wall and -Werror, which generally > >>> generates a warning along the following lines: > >>> > >>> warning: suggest parentheses around comparison in operand of & > >>> > >>That means, warnings caused by excessive inlining while compiling > >>maestro.c should also break the build if WARNS=1, right? Has anybody > >>encounter and getting annoyed by this? > > > >No, function inlining doesn't change the semantics of expressions. I misread Ariff's question. Please disregard. > So -Wall and -Werror doesn' result in issuing an error for each warning but > instead in an error for warnings, which are issued because the code in > question may change the semantic depending on the change which needs to be > done to get rid of the warning? Whether GCC prints 'warning:' or 'error:' is not changed by -Werror. I'm not sure understand the second part of your question. The warning is issued because a & b == c is parsed as a & (b == c). Stefan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051117143506.GL584>