Date: Thu, 1 Jun 2000 03:23:10 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Mike Smith <msmith@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/quot quot.c Message-ID: <Pine.BSF.4.21.0006010307460.744-100000@besplex.bde.org> In-Reply-To: <200005311656.JAA05296@mass.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 31 May 2000, Mike Smith wrote:
> > On Tue, 30 May 2000, Mike Smith wrote:
> >
> > > There are a heap of these that use "/dev" rather than PATH_DEV. What's
> > > the feeling on cleaning them all up?
> >
> > Hard-coded directories are almost as evil as hard-coded modifiers for
> > device names :-).
>
> 8) This sounds like an argument for sysctlbyname("path_dev") to me...
I only meant complete hard-coding of the strings. If everything used
macros for paths, then it might be possible to support dynamic paths by
#defining the macros as function calls.
> How do you feel about ANSI string concatenation, eg:
>
> open(PATH_DEV "rmt0", ...
This would break K&R support :-), and wouldn't work in most contexts
(the basename is normally from argv[]; for dump(8) it may be from the
environment).
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0006010307460.744-100000>