Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Jul 2009 07:35:39 -0500
From:      Robert Noland <rnoland@FreeBSD.org>
To:        Hans Petter Selasky <hselasky@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   Re: PERFORCE change 166673 for review
Message-ID:  <1248784539.73923.4.camel@balrog.2hip.net>
In-Reply-To: <200907281029.n6SATPUh047306@repoman.freebsd.org>
References:  <200907281029.n6SATPUh047306@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Tue, 2009-07-28 at 10:29 +0000, Hans Petter Selasky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=166673
> 
> Change 166673 by hselasky@hselasky_laptop001 on 2009/07/28 10:28:46
> 
> 	
> 	USB controller:
> 	 - allow disabling "root_mount_hold()" by setting a sysctl

Shouldn't this be a tuneable?  Possibly mirrored by a read only sysctl?

robert.

> Affected files ...
> 
> .. //depot/projects/usb/src/sys/dev/usb/controller/usb_controller.c#22 edit
> 
> Differences ...
> 
> ==== //depot/projects/usb/src/sys/dev/usb/controller/usb_controller.c#22 (text+ko) ====
> 
> @@ -79,6 +79,10 @@
>      "Debug level");
>  #endif
>  
> +static int usb_no_boot_wait = 0;
> +SYSCTL_INT(_hw_usb, OID_AUTO, no_boot_wait, CTLFLAG_RW, &usb_no_boot_wait, 0,
> +    "No device enumerate waiting at boot.");
> +
>  static uint8_t usb_post_init_called = 0;
>  
>  static devclass_t usb_devclass;
> @@ -132,8 +136,10 @@
>  		return (ENXIO);
>  	}
>  
> -	/* delay vfs_mountroot until the bus is explored */
> -	bus->bus_roothold = root_mount_hold(device_get_nameunit(dev));
> +	if (usb_no_boot_wait == 0) {
> +		/* delay vfs_mountroot until the bus is explored */
> +		bus->bus_roothold = root_mount_hold(device_get_nameunit(dev));
> +	}
>  
>  	if (usb_post_init_called) {
>  		mtx_lock(&Giant);
-- 
Robert Noland <rnoland@FreeBSD.org>
FreeBSD




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1248784539.73923.4.camel>