Date: Sat, 22 Jun 2013 01:21:45 -0500 From: Scot Hetzel <swhetzel@gmail.com> To: Lee Dilkie <lee@dilkie.com> Cc: Kimmo Paasiala <kpaasial@gmail.com>, Steven Hartland <killing@multiplay.co.uk>, Miroslav Lachman <000.fbsd@quip.cz>, freebsd-stable Stable <freebsd-stable@freebsd.org> Subject: Re: sshd didn't run after upgrade to FreeBSD 8.4 Message-ID: <CACdU%2Bf97rFrEMo1M1JkSKFcOtVbs5vD%2BsnLE-%2BaNxG8bQzNEMw@mail.gmail.com> In-Reply-To: <51C2CB42.4030301@dilkie.com> References: <51C22E11.3020008@quip.cz> <CA%2B7WWScSS16URJNQ3h1WjoXaBhG_gBn=ERb_SiCc4y%2BDhBeuKA@mail.gmail.com> <51C23ED9.7070107@quip.cz> <CA%2B7WWSfwXOh_g1hi-5C=hG8NRepNC1NzZjqscQdtqB=fGN2dWg@mail.gmail.com> <FB3070EFDC484C75AB519EA00A237D3E@multiplay.co.uk> <CA%2B7WWSebzFA2heKMAptnFdXYehyAhpNFki7XATzypTreArrc=A@mail.gmail.com> <51C2499B.2060209@quip.cz> <CA%2B7WWSevOGE5dQ4Ld_mBf_Dp7-f3%2B9AMz7uRihzeqM2rsZsGVA@mail.gmail.com> <51C2CB42.4030301@dilkie.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 20, 2013 at 4:28 AM, Lee Dilkie <lee@dilkie.com> wrote:
>
> On 6/19/2013 8:24 PM, Kimmo Paasiala wrote:
>> Ok, this is crazy. If you put one space after the VersionAddendum
>> keyword you get exactly what you want, an empty VersionAddendum
>> string. If there's no space but a newline right after the
>> VersionAddendum keyword, sshd(8) complains about the line and refuses
>> to start. So this is ok (without the single quotes, they are just to
>> show the endings of the lines):
>>
>> 'VersionAddendum '
>>
>> But this is not:
>>
>> 'VersionAddendum'
>>
>> What are the OpenSSH devs thinking?
>>
>> -Kimmo
>
> I'd call it a bug.
>
crypto/openssh/servconf.c
1553 case sVersionAddendum:
1554 if (cp == NULL)
1555 fatal("%.200s line %d: Missing
argument.", filename,
1556 linenum);
1557 len = strspn(cp, WHITESPACE);
1558 if (*activep && options->version_addendum == NULL) {
1559 if (strcasecmp(cp + len, "none") == 0)
1560 options->version_addendum = xstrdup("");
1561 else if (strchr(cp + len, '\r') != NULL)
1562 fatal("%.200s line %d: Invalid argument",
1563 filename, linenum);
1564 else
1565 options->version_addendum =
xstrdup(cp + len);
1566 }
1567 return 0;
Looks like if you specify:
VersionAddendum none
it won't display the additional info.
--
DISCLAIMER:
No electrons were maimed while sending this message. Only slightly bruised.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACdU%2Bf97rFrEMo1M1JkSKFcOtVbs5vD%2BsnLE-%2BaNxG8bQzNEMw>