Date: Sat, 12 Jun 2010 20:59:02 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua> Cc: freebsd-fs@freebsd.org Subject: Re: Testers: NFSv3 support for pxeboot for nfs diskless root Message-ID: <Pine.GSO.4.63.1006122058400.12503@muncher.cs.uoguelph.ca> In-Reply-To: <20100611103803.GA1855@pm513-1.comsys.ntu-kpi.kiev.ua> References: <Pine.GSO.4.63.1006091934390.22971@muncher.cs.uoguelph.ca> <20100611103803.GA1855@pm513-1.comsys.ntu-kpi.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 11 Jun 2010, Andrey Simonenko wrote: > On Wed, Jun 09, 2010 at 07:38:24PM -0400, Rick Macklem wrote: >> I put 3 patches (you need to apply them all) here: >> http://people.freebsd.org/~rmacklem/nfsdiskless-patches/ >> >> They convert lib/libstand/nfs.c and pxeboot to use NFSv3 instead >> of NFSv2 (unless built with OLD_NFSV2 defined). Initial test >> reports have been good. (one has it working ok and the other has >> a problem in an area not related to the patches, it appears) >> >> So, if others are interested in testing these, it would be >> appreciated, rick > > Shouldn't return values from malloc() calls be checked? > Also additional checks for NULL values before free() calls can be removed, > at least this will reduce size of code. There is PR/83424 related to this. > I have updated the patch with these changes. Thanks, rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.63.1006122058400.12503>