Date: Fri, 11 May 2018 17:31:35 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Bruce Evans <brde@optusnet.com.au> Cc: Ian Lepore <ian@freebsd.org>, "Jonathan T. Looney" <jtl@freebsd.org>, Stephen Hurd <shurd@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r333503 - stable/11/sys/net Message-ID: <201805120031.w4C0VZ8X077988@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <20180512100335.B1840@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, 11 May 2018, Ian Lepore wrote: > > > On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote: > >> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd@freebsd.org> wrote: > >>> > >>> > >>> Author: shurd > >>> Date: Fri May 11 20:40:26 2018 > >>> New Revision: 333503 > >>> URL: https://svnweb.freebsd.org/changeset/base/333503 > >>> > >>> Log: > >>> MFC r333329, r333366, r333373 > >>> > >>> r333329: Fix off-by-one error requesting tx interrupt > >>> r333366: Cleanup queues when iflib_device_register fails > >>> r333373: Log iflib_tx_structures_setup failure in function > >>> > >> Is this an acceptable style for MFC logs? > >> > >> I'm asking because I actually prefer this to reading (or compiling) the > >> concatenated log messages from several changes. However, I never knew it > >> was acceptable to summarize like this. If it is, I'd like to know so I can > >> adopt it for run-of-the-mill MFCs. > >> > >> Jonathan > > > > This used to be my preferred format, essentially to summarize what's > > being mfc'd. But then I started using the MFC Tracker tool [*] and it > > automatically generates a commit message that contains the full text, > > so I stopped trying to summarize things. > > > > [*] https://mfc.kernelnomicon.org/6/ > > It was the normal style with cvs (to avoid spamming the repository as > well as readers). Howver, one of many worse behaviours in svn is that > after checking out a branch, svn log only shows history for the branch, > so it is hard to find the full log messages even if you know that the > visible ones are only summaries. Though I don't care much for this behavior either you can get the original log entry if you get the changeset number by doing a svn log -c XXXXXX ^/head without that trailing ^/head you get a null output as that change does not exist on your current branch. You can also find the changeset number if the stable/X commit log does not have it by looking at the tail of a svn diff -c XXXXXX which has the mergeinfo in it, if it was done correctly. For this commit it would be svn diff -c 333503 | tail > Bruce -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805120031.w4C0VZ8X077988>