Date: Thu, 28 May 2026 19:26:34 +0000 From: "Sergey A. Osokin" <osa@freebsd.org> To: Jochen Neumeister <joneum@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 89e246c1b719 - main - www/lua-stream-nginx-module: Add new port Message-ID: <ahiW6nE0CRQbx50B@FreeBSD.org> In-Reply-To: <d95df92c-09af-4930-a3ec-cb460084de94@FreeBSD.org> References: <6a142091.31bc1.776944a4@gitrepo.freebsd.org> <ahdPXEN2pU7rv6Vb@FreeBSD.org> <d95df92c-09af-4930-a3ec-cb460084de94@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
Hi Jochen, thanks for the reply. On Wed, May 27, 2026 at 11:16:31PM +0200, Jochen Neumeister wrote: > Hi Sergey, > > the main reason for these ports is to have the related third-party module > dependencies directly available as standalone ports in the FreeBSD Ports > tree instead of only embedding them via GH_TUPLE. I still believe that's the best approach. > This makes it easier to manage upstream releases and required compatibility > adjustments in a more centralized and consistent way. It also helps to keep > updates and compatibility changes synchronized across the different NGINX > ports instead of maintaining the same source handling logic in multiple > places. Different NGINX ports may have different versions, flavors, something else, so support just one port for all of those variants look pretty complex to me. > That said, I absolutely understand your point regarding the currently > installed contents. The initial version was intentionally kept very close to > the upstream source tree to simplify integration and compatibility testing > during the transition from Makefile.extmod handling to standalone ports. > > I do agree that files such as .github metadata, CI files, git-related files, > and probably large parts of the test suite should not be packaged. I will > clean this up over the next days and reduce the installed contents to the > actually required module sources and related build files. Well, tests are definitely don't need to be a part of the final package. However, tests are very useful during build process: right after the build it's great idea to run tests against a fresh build to see the results and measure the quality of the final product. So, tests removal isn't good idea as well. Follow that, it's better to return back to the approach we had with a GH_TUPLE definition for a third-party module in nginx ports. > Am 27.05.26 um 22:09 schrieb Sergey A. Osokin: > > Hi Jochen, > > hope you're doing well. > > > > Could you please provide a reason for this port. > > I do believe that the existing schema with defining sources in > > the Makefile.extmod is good enough to support third-party > > modules. On other side, it's possible to create a port to > > make a binary module. > > > > I'm also curious why do we need to keep github attibutes, tests, > > and other staff as a package. [...] Thank you. -- Sergey A. Osokinhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ahiW6nE0CRQbx50B>