Date: Fri, 11 Dec 2015 14:49:08 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: Don Lewis <truckman@freebsd.org> Cc: mmcco@mykolab.com, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: XOR pt. 2 Message-ID: <CAGHfRMCWA%2BRR0P5kuJx_TckF4C4UXnMK3dPcfFXsCxWLKBb4oQ@mail.gmail.com> In-Reply-To: <201512112119.tBBLJOYC048783@gw.catspoiler.org> References: <20151211194204.GA26628@thinkpad.swarthmore.edu> <201512112119.tBBLJOYC048783@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 11, 2015 at 1:19 PM, Don Lewis <truckman@freebsd.org> wrote: > On 11 Dec, Michael McConville wrote: >> Note that IFCAP_HWCSUM has two bits set. Because of this, it doesn't XOR >> cleanly in the current if-else condition, but I'm not sure whether that >> was intended. I just wanted to pass this by people in case it was a >> logical bug. > > Yeah, the original code looks incorrect. If HWCSUM is totally disabled > and the user requests RXCSUM, then the current code will enable both > RXCSUM and TXCSUM. Please file a bug on bugzilla, CC erj, sbruno, and myself (ngie). Thanks! -NGie
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMCWA%2BRR0P5kuJx_TckF4C4UXnMK3dPcfFXsCxWLKBb4oQ>