Date: Sat, 28 Aug 2010 08:57:15 +0000 (UTC) From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/kern vfs_mount.c vfs_subr.c src/sys/sys mount.h Message-ID: <201008280857.o7S8vdo1056033@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
pjd 2010-08-28 08:57:15 UTC
FreeBSD src repository
Modified files:
sys/kern vfs_mount.c vfs_subr.c
sys/sys mount.h
Log:
SVN rev 211930 on 2010-08-28 08:57:15Z by pjd
There is a bug in vfs_allocate_syncvnode() failure handling in mount code.
Actually it is hard to properly handle such a failure, especially in MNT_UPDATE
case. The only reason for the vfs_allocate_syncvnode() function to fail is
getnewvnode() failure. Fortunately it is impossible for current implementation
of getnewvnode() to fail, so we can assert this and make
vfs_allocate_syncvnode() void. This in turn free us from handling its failures
in the mount code.
Reviewed by: kib
MFC after: 1 month
Revision Changes Path
1.317 +3 -5 src/sys/kern/vfs_mount.c
1.790 +5 -7 src/sys/kern/vfs_subr.c
1.252 +1 -1 src/sys/sys/mount.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201008280857.o7S8vdo1056033>