Date: Tue, 9 Jan 2007 09:24:50 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: cvs commit: src/sys/dev/msk if_msk.c Message-ID: <20070109002450.GA24958@cdnetworks.co.kr> In-Reply-To: <200701081135.59717.jhb@freebsd.org> References: <200701080019.l080Js9g077860@repoman.freebsd.org> <200701081135.59717.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 08, 2007 at 11:35:59AM -0500, John Baldwin wrote:
> On Sunday 07 January 2007 19:19, Pyun YongHyeon wrote:
> > yongari 2007-01-08 00:19:53 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > sys/dev/msk if_msk.c
> > Log:
> > Initialize legacy SYS_RES_IRQ resources before attempting to use MSI.
> > This fixes legacy SYS_RES_IRQ resource allocation failure when MSI is
> > disabled.
> >
> > Reported by: rrs
> > Tested by: rrs
>
> Gah, my bad. I would prefer to set it down before the 'if (msic == 2...)' so
> all the logic for it is in one place, but anyways, you should remove the
At first I thought that too. But mskc_attach() checks chip id and
then exits if the chip is not supported one. If that happens
mskc_detach() will call bus_release_resources() with invalid
SYS_RES_IRQ resources.
> now-duplicate setting here:
>
> } else {
> pci_release_msi(dev);
> sc->msk_irq_spec = msk_irq_spec_legacy;
Indeed, I'll do. Thanks a lot!
> }
>
> --
> John Baldwin
--
Regards,
Pyun YongHyeon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070109002450.GA24958>