Date: Tue, 09 Mar 2010 04:09:59 -0800 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r204909 - head/sbin/newfs Message-ID: <4B963A97.4040308@FreeBSD.org> In-Reply-To: <58991.1268134136@critter.freebsd.dk> References: <58991.1268134136@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote:
> In message <201003091031.o29AV3JO088200@svn.freebsd.org>, Maxim Sobolev writes:
>
>> Log:
>> Change secrorsize back to int, since that's the data type expected by the
>> ioctl(DIOCGSECTORSIZE). It creates issues on some architectures.
>
> Uhm, no, DIOCGSECTORSIZE requires an u_int:
>
> $ grep DIOCGSECTORSIZE /sys/sys/disk.h
> #define DIOCGSECTORSIZE _IOR('d', 128, u_int)
Heh, so it was a bug in the original code prior to my initial change.
However, I guess it's not a big issue anyway since media with sector
size larger that 2GiB hardly makes any sense today. Maybe in 100 years
from now this will be regular sector size, but by then we will probably
have 1024-bit wide ints anyway. :)
-Maxim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B963A97.4040308>