Date: Tue, 10 Apr 2012 22:38:39 +0200 From: Olli Hauer <ohauer@FreeBSD.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: Olli Hauer <ohauer@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net-mgmt/rancid Makefile distinfo pkg-plist ports/net-mgmt/rancid/files patch-bin-rancid.in patch-bin__control_rancid.in patch-etc::Makefile.am patch-etc::Makefile.in patch-etc__Makefile.am patch-etc__Makefile.in Message-ID: <4F849A4F.6030206@FreeBSD.org> In-Reply-To: <20120410194839.GB83964@dormouse.experts-exchange.com> References: <201204092207.q39M7Qdp013689@repoman.freebsd.org> <20120410194839.GB83964@dormouse.experts-exchange.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-04-10 21:48, Jason Helfman wrote: > On Mon, Apr 09, 2012 at 10:07:26PM +0000, Olli Hauer thus spake: >> ohauer 2012-04-09 22:07:26 UTC >> >> FreeBSD ports repository >> >> Modified files: >> net-mgmt/rancid Makefile distinfo pkg-plist >> Added files: >> net-mgmt/rancid/files patch-bin__control_rancid.in >> patch-etc__Makefile.am >> patch-etc__Makefile.in >> Removed files: >> net-mgmt/rancid/files patch-bin-rancid.in >> patch-etc::Makefile.am >> patch-etc::Makefile.in >> Log: >> - update to version 2.3.8 >> [...] > Can you please look at this pr, as I took it for a rancid update. > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166585 > > This port doesn't consider package installation users and clobbers existing > configurations. > > Per the Handbook: > If there is a very good reason not to install a working configuration file > by default, leave the @exec line out of pkg-plist and add a message pointing > out that the user must copy and edit the file before the software will work. > > Regarding the handbook entry, I don't know if this is the case for this > software, but I put the pr into feedback so I could engage the maintainer > regarding this, but have not heard anything. > Hi Jason, I can mybe agree on the first patch but the second seems problematic and should be optional http://www.shrubbery.net/pipermail/rancid-discuss/2012-February/006235.html The provided sample configuration will definitive not work. It is only a template since you have to customize it for your environ and create additional config files in the ~rancid home directory + mail/aliases entries +tacacs / radius accounts (or what ever you use for tools for authentication/authorisation in your network) ... Given for this port I find it more handy to have a the folder etc/rancid with a template the an empty folder with a .keepme file and a message from where I can copy the template.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F849A4F.6030206>