Date: Tue, 06 Jan 2009 13:55:34 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: christoph.mallon@gmx.de Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, bz@freebsd.org, src-committers@freebsd.org, sgk@troutmask.apl.washington.edu Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec Message-ID: <20090106.135534.742957024.imp@bsdimp.com> In-Reply-To: <49627592.60208@gmx.de> References: <20090105194210.P45399@maildrop.int.zabbadoz.net> <20090105204356.GA52934@troutmask.apl.washington.edu> <49627592.60208@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <49627592.60208@gmx.de>
Christoph Mallon <christoph.mallon@gmx.de> writes:
: Steve Kargl schrieb:
: > Stylistic changes (including whitespace changes) are hard on
: > the source repository and are to be avoided without good reason.
:
: Yet another anachronism in style(9).
: (Does that sentence even mean what I think it means? Somehow it sounds
: like "there is no good reason, but avoid them anyway" instead of "avoid
: them if you have no good reason".)
It means "Don't make white space changes because you can, make them
because you have some other reason for changing the code." If you are
just reading something and notice a space out of whack, don't bother.
If you are debugging the code, fixing a bug, adding a feature, go
ahead and fix that too: but make two commits.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090106.135534.742957024.imp>