Date: Tue, 30 Mar 2010 14:29:05 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Dag-Erling Smorgrav <des@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205834 - head/usr.bin/calendar Message-ID: <20100330142351.C5481@delplex.bde.org> In-Reply-To: <201003291320.o2TDKqfe066476@svn.freebsd.org> References: <201003291320.o2TDKqfe066476@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 29 Mar 2010, Dag-Erling Smorgrav wrote:
> Log:
> size_t is not equivalent to int on 64-bit platforms.
Neither is it on 16-63 or 65-infinity bit platforms, since it is not signed.
> Modified: head/usr.bin/calendar/parsedata.c
> ==============================================================================
> --- head/usr.bin/calendar/parsedata.c Mon Mar 29 12:32:16 2010 (r205833)
> +++ head/usr.bin/calendar/parsedata.c Mon Mar 29 13:20:52 2010 (r205834)
> @@ -39,9 +39,9 @@ __FBSDID("$FreeBSD$");
> static char *showflags(int flags);
> static int isonlydigits(char *s, int nostar);
> static const char *getmonthname(int i);
> -static int checkmonth(char *s, int *len, int *offset, const char **month);
> +static int checkmonth(char *s, size_t *len, size_t *offset, const char **month);
> static const char *getdayofweekname(int i);
> -static int checkdayofweek(char *s, int *len, int *offset, const char **dow);
> +static int checkdayofweek(char *s, size_t *len, size_t *offset, const char **dow);
len("size_t") is not equivalent to len("int") so s/size_t/int/g gives
ugly formatting on some platforms.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100330142351.C5481>