Date: Fri, 11 May 2018 17:24:20 -0700 From: John Baldwin <jhb@freebsd.org> To: "Jonathan T. Looney" <jtl@freebsd.org> Cc: Stephen Hurd <shurd@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r333503 - stable/11/sys/net Message-ID: <2564916.ivnyjH5XrP@ralph.baldwin.cx> In-Reply-To: <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com> References: <201805112040.w4BKeQvO053076@repo.freebsd.org> <CADrOrmuKJvUh7C_Y=KtG9WBtsQvaQHJ7=CFYjtvPKbrc=r1GMg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, May 11, 2018 07:31:40 PM Jonathan T. Looney wrote: > On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd@freebsd.org> wrote: > > > > Author: shurd > > Date: Fri May 11 20:40:26 2018 > > New Revision: 333503 > > URL: https://svnweb.freebsd.org/changeset/base/333503 > > > > Log: > > MFC r333329, r333366, r333373 > > > > r333329: Fix off-by-one error requesting tx interrupt > > r333366: Cleanup queues when iflib_device_register fails > > r333373: Log iflib_tx_structures_setup failure in function > > > > Is this an acceptable style for MFC logs? > > I'm asking because I actually prefer this to reading (or compiling) the > concatenated log messages from several changes. However, I never knew it > was acceptable to summarize like this. If it is, I'd like to know so I can > adopt it for run-of-the-mill MFCs. I prefer to summarize myself, but others have complained that you then can't grep for strings used in the head commit log to determine if a change has been MFC'd (assuming you don't have the head rev handy and want to search by some name / string you remember). In particular I preferred doing a "squash" of fixup type commits when doing MFCs, but I've relented to doing the full logs. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2564916.ivnyjH5XrP>