Date: Sun, 26 Dec 2004 10:29:58 -0800 From: Sam Leffler <sam@errno.com> To: Darren Reed <darrenr@hub.freebsd.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet ip_fil.h Message-ID: <41CF0326.9090704@errno.com> In-Reply-To: <20041226144953.GB93350@hub.freebsd.org> References: <200412250048.iBP0mSto090429@repoman.freebsd.org> <20041226083448.GA93350@hub.freebsd.org> <xzppt0x2px3.fsf@dwp.des.no> <20041226144953.GB93350@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Darren Reed wrote: > On Sun, Dec 26, 2004 at 01:40:40PM +0100, Dag-Erling Sm?rgrav wrote: > >>Darren Reed <darrenr@hub.freebsd.org> writes: >> >>>Sorry about breaking HEAD builds, some patches got left behind when >>>I generated diffs and took them across to the freebsd tree :( >> >>You would have caught that if you'd tried to build before committing. > > > And what if I said I did? I think what you're trying to say is build what > you intend to commit before you commit. I don't have the luxury of having > systems around that i can keep upto date with each of 4-stable and 5-stable > and -current, as well as the latest 4.x and 5.x release (what users use.) > I believe you can cross-build from a system you have, but I cannot tell from the above what systems you actually run. > >>You seem to fail to do that with appalling regularity. > > > It's unfortunate that it happens but it does. > > I wish the solution was as easy as your implied suggestion but, > sorry, it isn't. Have you considered finding another committer to take responsibility for this code? If you can't run an up to date current system to validate changes (not just compilation but also stability in operation) then it sounds like there will continue to be problems. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41CF0326.9090704>