Date: Sun, 21 Aug 2011 12:48:38 +0100 From: Chris Rees <crees@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Rene Ladan <rene@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www/chromium Makefile Message-ID: <CADLo83-G2ofiaLZiTA_%2BB2FBTAw-AUw2%2BGHWfEo%2BMno7QJXeRQ@mail.gmail.com> In-Reply-To: <20110821114454.GA77777@FreeBSD.org> References: <201108211100.p7LB0cB7060742@repoman.freebsd.org> <CADLo838r7ksFKTjB24NBVTtnyDaf54jdz9aQ9Ggb22CtsvA9ng@mail.gmail.com> <20110821114454.GA77777@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/8/21 Alexey Dokuchaev <danfe@freebsd.org>:
> On Sun, Aug 21, 2011 at 12:04:37PM +0100, Chris Rees wrote:
>> On 21 August 2011 12:00, Rene Ladan <rene@freebsd.org> wrote:
>> > rene =A0 =A0 =A0 =A02011-08-21 11:00:38 UTC
>> >
>> > =A0Modified files:
>> > =A0 =A0www/chromium =A0 =A0 =A0 =A0 Makefile
>> > =A0Log:
>> > =A0Do not hardcode the patch directory as "files", use ${FILESDIR} ins=
tead.
>>
>> Shouldn't it be PATCHDIR?
>
> Ideally, only one should stay, I don't really care which one (although
> FILESDIR is maybe a bit better as it's more generic -- there might be not
> only patches, but drop-in files, etc).
>
> I wanted to look at merging FILESDIR/PATCHDIR logic in bpm several years
> ago, but didn't go much further.
>
I'd agree on FILESDIR.
Anyone have a problem with adding a section on
wiki/PortsLongtermTargets about ports that use PATCHDIR? This
inconsistency is a little strange.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-G2ofiaLZiTA_%2BB2FBTAw-AUw2%2BGHWfEo%2BMno7QJXeRQ>