Date: Thu, 25 Jul 2013 09:29:48 +0000 (UTC) From: Ulrich Spoerlein <uqs@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r253645 - head/sys/dev/sound/pci Message-ID: <201307250929.r6P9TmYi058348@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: uqs Date: Thu Jul 25 09:29:48 2013 New Revision: 253645 URL: http://svnweb.freebsd.org/changeset/base/253645 Log: snd_ds1(4): Fix order of arguments for stereo/16bit mode This function is called 4 times in this file, with swapped parameter ordering. Fix the function definition instead of all the call sites. 16bit/stereo or 8bit/mono playback is unaffected and was probably working fine before, this should fix 16bit/mono and 8bit/stereo playback. Found by: Coverity Scan, CID 1006688 Modified: head/sys/dev/sound/pci/ds1.c Modified: head/sys/dev/sound/pci/ds1.c ============================================================================== --- head/sys/dev/sound/pci/ds1.c Thu Jul 25 09:12:46 2013 (r253644) +++ head/sys/dev/sound/pci/ds1.c Thu Jul 25 09:29:48 2013 (r253645) @@ -365,7 +365,7 @@ ds_allocpslot(struct sc_info *sc) } static int -ds_initpbank(volatile struct pbank *pb, int ch, int b16, int stereo, u_int32_t rate, bus_addr_t base, u_int32_t len) +ds_initpbank(volatile struct pbank *pb, int ch, int stereo, int b16, u_int32_t rate, bus_addr_t base, u_int32_t len) { u_int32_t lv[] = {1, 1, 0, 0, 0}; u_int32_t rv[] = {1, 0, 1, 0, 0};
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307250929.r6P9TmYi058348>