Date: Wed, 2 Apr 2014 19:54:34 +0200 From: Peter Holm <peter@holm.cc> To: Craig Rodrigues <rodrigc@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: ATF work Message-ID: <20140402175434.GA75279@x2.osted.lan> In-Reply-To: <CAG=rPVep6wrby4cej0fWSNtYrRhHLn5eOjDsNWWTYv0RpjDqUw@mail.gmail.com> References: <20140402085349.GA61802@x2.osted.lan> <CAOtMX2gGn5NMpvSR0FF=z70cUCDn=vTQvVWo2mXk8t9UrNKzuA@mail.gmail.com> <CAG=rPVep6wrby4cej0fWSNtYrRhHLn5eOjDsNWWTYv0RpjDqUw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 02, 2014 at 10:21:26AM -0700, Craig Rodrigues wrote: > On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers <asomers@freebsd.org> wrote: > > On Wed, Apr 2, 2014 at 2:53 AM, Peter Holm <peter@holm.cc> wrote: > >> I have uploaded a snapshot of the ATF work done for EMC Isilon, > >> based primarily on Garrett Cooper's work. > >> > >> http://people.freebsd.org/~pho/FreeBSD-HEAD-ATF-Isilon-20140401.diff.xz > >> + > >> chmod +x /usr/src/lib/libc/tests/net/gen_ether_subr > > > > Holy patch queue, Batman! There's fifty thousand lines of code in here! > > > When a patch is that big, it becomes very difficult to review. > > You might want to consider forking a copy on github of the > https://github.com/freebsd/freebsd repository and maintaining the patch there > until it is MFC'd: > > https://help.github.com/articles/fork-a-repo > https://help.github.com/articles/syncing-a-fork > > It's not perfect but some of the web interface tools around the github > ecosystem make reviewing patches (and contributing updates) a bit easier. > Thank you for the references. I will definitely look at this. -- Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140402175434.GA75279>