Date: Fri, 01 Mar 2024 21:20:51 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Gleb Popov <arrowd@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: c2afef5c2587 - main - Features/testing.mk: Introduce the TESTING_UNSAFE knob. Message-ID: <ab6429b3b2004cd8ad9e7ed0b563a5c9@mail.infomaniak.com> In-Reply-To: <202403011927.421JRqxx065749@gitrepo.freebsd.org> References: <202403011927.421JRqxx065749@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1709324451_c04ed208324fd26229f6468c7211f23b_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-03-01T20:27:52.000+01:00, Gleb Popov <arrowd@FreeBSD.org> wrote:= >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0arrowd: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org= /ports/commit/?id=3Dc2afef5c2587738b16b52def34edcebe4e421905 >=C2=A0 >= =C2=A0commit=C2=A0c2afef5c2587738b16b52def34edcebe4e421905 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Gleb=C2=A0Popov=C2=A0<arrowd@Fre= eBSD.org> >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-03-01=C2=A019:25:37= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Gleb= =C2=A0Popov=C2=A0<arrowd@FreeBSD.org> >=C2=A0 >=C2=A0CommitDate:=C2= =A02024-03-01=C2=A019:26:53=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0Features/testing.mk=C2=A0[http://testing.mk]:=C2=A0Introduce= =C2=A0the=C2=A0TESTING_UNSAFE=C2=A0knob. >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Approved=C2=A0by:= =C2=A0=C2=A0=C2=A0=C2=A0tcberner >=C2=A0 >=C2=A0--- >=C2=A0 >=C2= =A0=C2=A0Mk/Features/testing.mk=C2=A0[http://testing.mk]=C2=A0|=C2=A05= =C2=A0++++- >=C2=A0 >=C2=A0=C2=A01=C2=A0file=C2=A0changed,=C2=A04=C2= =A0insertions(+),=C2=A01=C2=A0deletion(-) >=C2=A0 >=C2=A0diff=C2=A0--gi= t=C2=A0a/Mk/Features/testing.mk=C2=A0[http://testing.mk]=C2=A0b/Mk/Features= /testing.mk=C2=A0[http://testing.mk] >=C2=A0 >=C2=A0index=C2=A015af7e28= eb7c..a266f6effe91=C2=A0100644 >=C2=A0 >=C2=A0---=C2=A0a/Mk/Features/te= sting.mk=C2=A0[http://testing.mk] >=C2=A0 >=C2=A0+++=C2=A0b/Mk/Features= /testing.mk=C2=A0[http://testing.mk] >=C2=A0 >=C2=A0@@=C2=A0-4,12=C2= =A0+4,15=C2=A0@@ >=C2=A0 >=C2=A0=C2=A0#=C2=A0-=C2=A0If=C2=A0set,=C2= =A0and=C2=A0the=C2=A0port=C2=A0supports=C2=A0it,=C2=A0the=C2=A0software's= =C2=A0test=C2=A0suite=C2=A0will=C2=A0be=C2=A0compiled >=C2=A0 >=C2= =A0=C2=A0#=C2=A0=C2=A0=C2=A0and=C2=A0run=C2=A0during=C2=A0the=C2=A0normal= =C2=A0building=C2=A0pipeline=C2=A0between=C2=A0'stage'=C2=A0and=C2=A0'packa= ge' >=C2=A0 >=C2=A0=C2=A0#=C2=A0=C2=A0=C2=A0stages. >=C2=A0 >=C2= =A0+#=C2=A0-=C2=A0A=C2=A0port=C2=A0may=C2=A0define=C2=A0TESTING_UNSAFE=3Dye= s=C2=A0if=C2=A0its=C2=A0tests=C2=A0are=C2=A0known=C2=A0to=C2=A0fail=C2= =A0at=C2=A0the >=C2=A0 >=C2=A0+#=C2=A0=C2=A0=C2=A0moment. >=C2=A0 >= =C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0.if=C2=A0!defined(_TESTING_MK_INCLUDE= D) >=C2=A0 >=C2=A0=C2=A0_TESTING_MK_INCLUDED=3D=C2=A0=C2=A0=C2=A0=C2= =A0yes >=C2=A0 >=C2=A0=C2=A0TESTING_Include_MAINTAINER=3D=C2=A0=C2= =A0=C2=A0=C2=A0portmgr@FreeBSD.org >=C2=A0 >=C2=A0=C2=A0 >=C2=A0 >= =C2=A0+.=C2=A0=C2=A0if=C2=A0!defined(TESTING_UNSAFE) >=C2=A0 >=C2=A0= =C2=A0_TESTING_PACKAGE_DEP=3D=C2=A0=C2=A0=C2=A0=C2=A0test >=C2=A0 >= =C2=A0+.=C2=A0=C2=A0endif >=C2=A0 >=C2=A0=C2=A0 >=C2=A0 >=C2=A0= =C2=A0.endif >=C2=A0 >=C2=A0- Hi, Thanks for adding this, how= ever this won't work on ports that uses TEST menu option as far as I can = tell which is a relatively common occurence? Se also https://cgit.= freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495 Best regards, = Daniel --_=_swift_1709324451_c04ed208324fd26229f6468c7211f23b_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <div>On 2024-03-01T20:27:52.000+01:00, Gleb Popov <arrowd@FreeBSD.org>= ; wrote:<br></div><div class=3D"ik_mail_quote answerContentMessage"><blockq= uote class=3D"ws-ng-quote"><pre style=3D"white-space: normal;"><div>The bra= nch main has been updated by arrowd:<br></div><div><br></div><div>URL: <a d= ata-ik=3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" = href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3Dc2afef5c2587738b16b52de= f34edcebe4e421905" target=3D"_blank">https://cgit.FreeBSD.org/ports/commit/= ?id=3Dc2afef5c2587738b16b52def34edcebe4e421905</a><br></div><div><br></div>= <div>commit c2afef5c2587738b16b52def34edcebe4e421905<br></div><div>Author: = Gleb Popov <<a class=3D"defaultMailLink" href=3D"mailto:arrowd@FreeB= SD.org">arrowd@FreeBSD.org</a>><br></div><div>AuthorDate: 2024-03-01 19:= 25:37 +0000<br></div><div>Commit: Gleb Popov <<a class=3D"defaultMai= lLink" href=3D"mailto:arrowd@FreeBSD.org">arrowd@FreeBSD.org</a>><br></d= iv><div>CommitDate: 2024-03-01 19:26:53 +0000<br></div><div><br></div><div>= Features/<a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" class=3D"= defaultMailLink" href=3D"http://testing.mk" target=3D"_blank">testing.mk</a= >: Introduce the TESTING_UNSAFE knob.<br></div><div> <br></div><div> = Approved by: tcberner<br></div><div>---<br></div><div> Mk/Features/<a da= ta-ik=3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" h= ref=3D"http://testing.mk" target=3D"_blank">testing.mk</a> | 5 ++++-<br></d= iv><div> 1 file changed, 4 insertions(+), 1 deletion(-)<br></div><div><br><= /div><div>diff --git a/Mk/Features/<a data-ik=3D"ik-secure" rel=3D"noopener= noreferrer" class=3D"defaultMailLink" href=3D"http://testing.mk" target=3D= "_blank">testing.mk</a> b/Mk/Features/<a data-ik=3D"ik-secure" rel=3D"noope= ner noreferrer" class=3D"defaultMailLink" href=3D"http://testing.mk" target= =3D"_blank">testing.mk</a><br></div><div>index 15af7e28eb7c..a266f6effe91 1= 00644<br></div><div>--- a/Mk/Features/<a data-ik=3D"ik-secure" rel=3D"noope= ner noreferrer" class=3D"defaultMailLink" href=3D"http://testing.mk" target= =3D"_blank">testing.mk</a><br></div><div>+++ b/Mk/Features/<a data-ik=3D"ik= -secure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" href=3D"http= ://testing.mk" target=3D"_blank">testing.mk</a><br></div><div>@@ -4,12 +4,1= 5 @@<br></div><div> # - If set, and the port supports it, the software's te= st suite will be compiled<br></div><div> # and run during the normal buil= ding pipeline between 'stage' and 'package'<br></div><div> # stages.<br><= /div><div>+# - A port may define TESTING_UNSAFE=3Dyes if its tests are know= n to fail at the<br></div><div>+# moment.<br></div><div> <br></div><div> = .if !defined(_TESTING_MK_INCLUDED)<br></div><div> _TESTING_MK_INCLUDED=3D= =09yes<br></div><div> TESTING_Include_MAINTAINER=3D=09<a class=3D"defaultMa= ilLink" href=3D"mailto:portmgr@FreeBSD.org">portmgr@FreeBSD.org</a><br></di= v><div> <br></div><div>+. if !defined(TESTING_UNSAFE)<br></div><div> _TEST= ING_PACKAGE_DEP=3D=09test<br></div><div>+. endif<br></div><div> <br></div>= <div> .endif<br></div><div>-<br></div></pre></blockquote></div><div>Hi,<br>= </div><div><br></div><div>Thanks for adding this, however this won't work o= n ports that uses TEST menu option as far as I can tell which is a relative= ly common occurence?<br></div><div><br></div><div>Se also <a href=3D"https:= //cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495" target=3D"_blank= " rel=3D"noopener noreferrer" data-ik=3D"ik-secure">https://cgit.freebsd.or= g/ports/tree/Mk/bsd.options.desc.mk#n495</a><br></div><div>Best regards,<br= ></div><div>Daniel<br></div><div ><div><br></div></div> --_=_swift_1709324451_c04ed208324fd26229f6468c7211f23b_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ab6429b3b2004cd8ad9e7ed0b563a5c9>