Date: Tue, 21 Jan 2014 12:03:08 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: PATCH: fix "WITH_TESTS=yes make installworld" on amd64 Message-ID: <9EF7C79E-B9D0-4DDE-A425-8D6FFBC0FC1E@gmail.com> In-Reply-To: <CAOtMX2jvBirXFSha7FTvsszQFfjVjWOLdfWEeky3VXnEE0Krjg@mail.gmail.com> References: <CAOtMX2jvBirXFSha7FTvsszQFfjVjWOLdfWEeky3VXnEE0Krjg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 21, 2014, at 10:00, Alan Somers <asomers@freebsd.org> wrote:
>=20
> I finally found the problem. Make was trying to install tests during
> the install32 phase. During this phase, it adds "lib32" to
> MAKEOBJDIRPREFIX, so it can't find the tests, which were never built
> with that prefix. The command worked fine when I ran it under "make
> buildenv", because that uses the normal MAKEOBJDIRPREFIX.
>=20
> I'm not sure what prevented the tests from being built during the
> lib32 build phase, but this patch will disable tests during both
> building and installing 32 bit libraries.
>=20
> At work, we never noticed this problem in our SpectraBSD branch
> because we set WITHOUT_LIB32=3D1 in /etc/src.conf.
>=20
>=20
> Does this patch look ok? Should I be disabling tests some other way?
> I looked for a way to disable recursing into the tests directories
> whenever LIBRARIES_ONLY was set, but didn't see an easy way.
>=20
>=20
> -Alan
>=20
>=20
> Index: Makefile.inc1
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- Makefile.inc1 (revision 260986)
> +++ Makefile.inc1 (working copy)
> @@ -417,7 +417,7 @@
> -DNO_LINT
>=20
> LIB32WMAKE=3D ${LIB32WMAKEENV} ${MAKE} ${LIB32WMAKEFLAGS} \
> - -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML
> + -DWITHOUT_MAN -DWITHOUT_INFO -DWITHOUT_HTML -DNO_TESTS
> LIB32IMAKE=3D ${LIB32WMAKE:NINSTALL=3D*:NDESTDIR=3D*:N_LDSCRIPTROOT=3D*=
} -DNO_INCS \
> ${IMAKE_INSTALL}
> .endif
I have to check my git tree, but I'm pretty sure this was already accoun=
ted for (along with some other changes).
I'll get back to sometime today about this...
Thanks!
-Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9EF7C79E-B9D0-4DDE-A425-8D6FFBC0FC1E>