Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Nov 2011 09:40:10 +0100
From:      Hans Petter Selasky <hselasky@c2i.net>
To:        freebsd-usb@freebsd.org
Subject:   Re: [uslcom][patch] Add GPIO support
Message-ID:  <201111120940.10981.hselasky@c2i.net>
In-Reply-To: <CAB-7mS6-kZk_Vxyd%2BQ-cGBEdAzqw=-QAh4GnH2OPVYC1fE5hqA@mail.gmail.com>

index | next in thread | previous in thread | raw e-mail

On Friday 11 November 2011 22:06:19 JD Louw wrote:
> JD Louw <jdl.ntq@gmail.com>

Hi,

In IOCTL's you shouldn't cast *(uint8_t *)ptr to *(int *)ptr and forth and 
back, because this only works on little endian machines.

Else your patch looks very good. I'm impressed.

Please download the latest version of the uslcom driver and test that nothing 
is broken.

Thanks for your patch submission!

http://svn.freebsd.org/changeset/base/227463

--HPS


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201111120940.10981.hselasky>