Date: Fri, 19 Nov 2010 13:09:24 +0300 From: Sergey Kandaurov <pluknet@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: old references to vfs_mountroot_try() Message-ID: <AANLkTi=opRz6iP8_-KR9uM904KHRnR6NkDu6o75Uet%2Bv@mail.gmail.com> In-Reply-To: <20101118231411.GA5121@freebsd.org> References: <20101118231411.GA5121@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 November 2010 02:14, Alexander Best <arundel@freebsd.org> wrote:
> hi there,
>
> vfs_mountroot_try() seems to have been removed, yet the src still contains
> three references to it:
>
> vfs_mount.c:386
> vfs_mount.c:723
> freebsd32_misc.c:2368
>
So, what about just to rename those comments to reflect function name change?
Index: sys/kern/vfs_mount.c
===================================================================
--- sys/kern/vfs_mount.c (revision 215516)
+++ sys/kern/vfs_mount.c (working copy)
@@ -383,7 +383,7 @@
* Filter out MNT_ROOTFS. We do not want clients of nmount() in
* userspace to set this flag, but we must filter it out if we want
* MNT_UPDATE on the root file system to work.
- * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
+ * MNT_ROOTFS should only be set in the kernel in parse_mount().
*/
uap->flags &= ~MNT_ROOTFS;
@@ -720,7 +720,7 @@
* Filter out MNT_ROOTFS. We do not want clients of mount() in
* userspace to set this flag, but we must filter it out if we want
* MNT_UPDATE on the root file system to work.
- * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
+ * MNT_ROOTFS should only be set in the kernel in parse_mount().
*/
uap->flags &= ~MNT_ROOTFS;
Index: sys/compat/freebsd32/freebsd32_misc.c
===================================================================
--- sys/compat/freebsd32/freebsd32_misc.c (revision 215516)
+++ sys/compat/freebsd32/freebsd32_misc.c (working copy)
@@ -2365,7 +2365,7 @@
* Filter out MNT_ROOTFS. We do not want clients of nmount() in
* userspace to set this flag, but we must filter it out if we want
* MNT_UPDATE on the root file system to work.
- * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try().
+ * MNT_ROOTFS should only be set in the kernel in parse_mount().
*/
uap->flags &= ~MNT_ROOTFS;
--
wbr,
pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTi=opRz6iP8_-KR9uM904KHRnR6NkDu6o75Uet%2Bv>