Date: Sun, 3 Jun 2018 06:52:38 +0800 From: blubee blubeeme <gurenchan@gmail.com> To: Vladimir Kondratyev <vladimir@kondratyev.su> Cc: Allan Jude <allanjude@freebsd.org>, freebsd-current@freebsd.org, owner-freebsd-current@freebsd.org Subject: Re: Proper way to remove never used ioctls Message-ID: <CALM2mEkmw-f8uJUtZF4=U7XVvwVkYTtsjF1idpu_wy%2BSCKZSoA@mail.gmail.com> In-Reply-To: <8f0bd4c0195ecaf1038268831576c461@kondratyev.su> References: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> <CANCZdfoScVOooB%2Bm9Z3CmsVzXyKC6D_wht2CQBbFytVyRfDnMQ@mail.gmail.com> <e80e9b2a-4165-feba-a689-e340a1062268@freebsd.org> <8f0bd4c0195ecaf1038268831576c461@kondratyev.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 3, 2018, 02:34 Vladimir Kondratyev <vladimir@kondratyev.su> wrote: > On 2018-06-02 20:36, Allan Jude wrote: > > On 2018-06-02 11:03, Warner Losh wrote: > >> On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev > >> <vladimir@kondratyev.su> > >> wrote: > >> > >>> Hi, > >>> > >>> Our sys/mouse.h header has a definition of MOUSE_GETVARS and > >>> MOUSE_SETVARS > >>> ioctls which are not documented and only stubbed in a few drivers: > >>> mse(4), > >>> psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS > >>> implemented in psm(4) > >>> > >>> Given the fact that they were introduced 20 years ago, implementation > >>> was > >>> never completed and googling on them shows no traces of usage in > >>> indexed > >>> universe, is it acceptable to just drop both defines and > >>> implementation > >>> w.o. leaving any COMPAT_FREEBSD shims? > >> > >> > >> I'd prepare a patch just removing them. I'd then send that patch to > >> the > >> ports mgr team and request a exp-run. Details for that can be found in > >> > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html > >> > >> Once that's done, submit a Phabricator review and send me email. I'll > >> make > >> sure it gets pushed in if there's no objections. > >> > >> Warner > > > > This indeed seems to be the correct approach. The exp-run will compile > > the entire ports tree against the patched base system, and identify any > > 3rd party software that fails to compile because of the change. > > Thank you, Allan and Warner! I'll follow yours advice. > > -- > WBR > Vladimir Kondratyev > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > This was great information. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALM2mEkmw-f8uJUtZF4=U7XVvwVkYTtsjF1idpu_wy%2BSCKZSoA>