Date: Wed, 21 Sep 2005 18:16:12 GMT From: soc-chenk <soc-chenk@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 84065 for review Message-ID: <200509211816.j8LIGC7D000603@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=84065 Change 84065 by soc-chenk@soc-chenk_leavemealone on 2005/09/21 18:15:20 fix the bogus LOR fix Submitted by: soc-chenk Affected files ... .. //depot/projects/soc2005/fuse4bsd2/Changelog#11 edit .. //depot/projects/soc2005/fuse4bsd2/README.html#6 edit .. //depot/projects/soc2005/fuse4bsd2/fuse_module/fuse.c#9 edit Differences ... ==== //depot/projects/soc2005/fuse4bsd2/Changelog#11 (text+ko) ==== @@ -1,3 +1,9 @@ +Wed Sep 21 20:05:27 CEST 2005 at node: creo.hu, nick: csaba + tagged 0.2.11 + +Wed Sep 21 20:04:50 CEST 2005 at node: creo.hu, nick: csaba + * fix the bogus LOR fix + Wed Sep 21 11:58:29 CEST 2005 at node: creo.hu, nick: csaba tagged 0.2.1 ==== //depot/projects/soc2005/fuse4bsd2/README.html#6 (text+ko) ==== @@ -55,7 +55,7 @@ </li> <li> <p> - The FreeBSD module. Source tarballs are provided at <a class="external" href="http://creo.hu/~csaba/projects/fuse4bsd/downloads/"><img src="/classic/img/moin-www.png" alt="[WWW]" height="11" width="11">http://creo.hu/~csaba/projects/fuse4bsd/downloads/</a>; under the name <tt>fuse4bsd-</tt><em><version></em><tt>.tar.*</tt> (latest release is <strong>0.2.1</strong>, date of release: <strong>21th Sep 2005</strong>). The current code is available via Darcs, you can fetch it by + The FreeBSD module. Source tarballs are provided at <a class="external" href="http://creo.hu/~csaba/projects/fuse4bsd/downloads/"><img src="/classic/img/moin-www.png" alt="[WWW]" height="11" width="11">http://creo.hu/~csaba/projects/fuse4bsd/downloads/</a>; under the name <tt>fuse4bsd-</tt><em><version></em><tt>.tar.*</tt> (latest release is <strong>0.2.11</strong>, date of release: <strong>21th Sep 2005</strong>). The current code is available via Darcs, you can fetch it by <pre> darcs get http://creo.hu/~csaba/darcs-repos/fuse4bsd</pre>; command, or via <a class="external" href="http://perforce.freebsd.org/depotTreeBrowser.cgi?FSPC=/depot/projects/soc2005/fuse4bsd2"><img src="/classic/img/moin-www.png" alt="[WWW]" height="11" width="11">Perforce</a> (you can use this latter link for online source code browsing). </p> </li> ==== //depot/projects/soc2005/fuse4bsd2/fuse_module/fuse.c#9 (text+ko) ==== @@ -4569,13 +4569,21 @@ */ fvdat = vp->v_data; + /* + * It seemed to be a good idea to lock the filehandle lock only before + * doing iterate_filehandle but that configuration is suspected to cause + * LOR alerts, so now we get the filehandle lock before the fuse_data + * lock. + */ sx_slock(&fvdat->fh_lock); if ((err = fdisp_get_vopdata(&fdi, vp->v_mount))) - return (err); + goto out; iterate_filehandles(vp, td, NULL, 0, fuse_fsync_filehandle, &fdi); sx_sunlock(fdi.slock); + +out: sx_sunlock(&fvdat->fh_lock); return (err); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200509211816.j8LIGC7D000603>