Date: Tue, 10 Jul 2001 14:18:40 -0400 (EDT) From: Mike Barcroft <mike@q9media.com> To: Mark Murray <markm@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/libpam pam_mod_misc.h pam_std_option.c Message-ID: <200107101818.f6AIIeq20534@coffee.q9media.com>
next in thread | raw e-mail | index | archive | help
Mark Murray <markm@FreeBSD.org> writes:
> markm 2001/07/10 09:59:31 PDT
>
> Modified files:
> lib/libpam/libpam pam_mod_misc.h pam_std_option.c
> Log:
> Fix a horrible bug introduced by myself where the options collection
> keeps on growing as the module stack is parsed.
>
> Revision Changes Path
> 1.5 +2 -2 src/lib/libpam/libpam/pam_mod_misc.h
> 1.5 +19 -10 src/lib/libpam/libpam/pam_std_option.c
[...]
> + found = 0;
> + for (i = 0; std_options[i].name; i++)
> + if (strcmp((char *)oo->name,
> + std_options[i].name) == 0)
> + found = 1;
> + if (!found) {
> + std_options[j].name = oo->name;
> + std_options[j].value = oo->value;
> + j++;
> + }
[...]
Shouldn't there be a break in the for loop after found is set?
Best regards,
Mike Barcroft
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200107101818.f6AIIeq20534>