Date: Mon, 17 Nov 2025 12:39:30 -0500 From: Adam Weinberger <adamw@freebsd.org> To: Chris <i.h8.git@bsdforge.com> Cc: ports-committers@freebsd.org, Zsolt Udvari <uzsolt@freebsd.org>, Nuno Teixeira <eduardo@freebsd.org>, Max Brazhnikov <makc@freebsd.org>, =?UTF-8?Q?Jes=C3=BAs_Daniel_Colmenares_Oviedo?= <dtxdf@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, DtxdF@disroot.org, portmgr@freebsd.org Subject: Re: Literal text WWW in ports Makefile Message-ID: <CAP7rwchX7-EajmefbCHWz=%2Bq5tcpbDVw5NNqLWP_ity8TO7%2BdQ@mail.gmail.com> In-Reply-To: <f9fd69489837e8187e1665cfa20eae35@BSDforge.com> References: <202511150000.5AF00UV0020031@gitrepo.freebsd.org> <1806919.NDq42KOioK@mercury> <aRjJzjzNL9MsvbnV@bsd-zsolt> <4220452.uxbk0vzbMu@mercury> <f9fd69489837e8187e1665cfa20eae35@BSDforge.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Nov 17, 2025 at 12:12 PM Chris <i.h8.git@bsdforge.com> wrote: > On 2025-11-15 12:21, Max Brazhnikov wrote: > > On Sat, 15 Nov 2025 19:43:26 +0100 Zsolt Udvari wrote: > >> On Sat, Nov 15, 2025 at 09:16:30PM +0300, Max Brazhnikov wrote: > >> > WWW also was a literal text when it just migrated to Makefile. Why it > should > >> > be obfuscated now? No difference for the make, but less convenient > for humans: > >> > plain text url can be opened from the editor without running the make. > >> > >> The github, gitlab and pear set a WWW (if it isn't defined in Makefile) > so > >> you can't open the url without running make. If you want see plain text > >> url should remove these definitions from Mk/bsd.sites.mk and > > > > I'm ok with this, framework may set WWW for ports, and ports can > redefine it > > if needed. But if WWW is explicitly set in the Makefile it should be > plain > > url. > > If either is possible. Why should it not be what is easiest or most > efficient > for the > Maintainer/Developer at the time? > Because it should be what is most helpful and useful for end-users, not the maintainer. It's a worse experience for the end-user, doesn't actually save the maintainer any time, and really the only benefit is that the port needs fewer changes if the name of the program suddenly changes, which occurs once every never. We are not the customer, nor is make(1). -- Adam Weinberger adamw@adamw.org // adamw@FreeBSD.org [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif">On Mon, Nov 17, 2025 at 12:12 PM Chris <<a href="mailto:i.h8.git@bsdforge.com">i.h8.git@bsdforge.com</a>> wrote:</div></div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2025-11-15 12:21, Max Brazhnikov wrote:<br> > On Sat, 15 Nov 2025 19:43:26 +0100 Zsolt Udvari wrote:<br> >> On Sat, Nov 15, 2025 at 09:16:30PM +0300, Max Brazhnikov wrote:<br> >> > WWW also was a literal text when it just migrated to Makefile. Why it should<br> >> > be obfuscated now? No difference for the make, but less convenient for humans:<br> >> > plain text url can be opened from the editor without running the make.<br> >> <br> >> The github, gitlab and pear set a WWW (if it isn't defined in Makefile) so<br> >> you can't open the url without running make. If you want see plain text<br> >> url should remove these definitions from Mk/<a href="http://bsd.sites.mk" rel="noreferrer" target="_blank">bsd.sites.mk</a> and<br> > <br> > I'm ok with this, framework may set WWW for ports, and ports can redefine it<br> > if needed. But if WWW is explicitly set in the Makefile it should be plain <br> > url.<br> <br> If either is possible. Why should it not be what is easiest or most efficient <br> for the<br> Maintainer/Developer at the time?<br></blockquote><div><br></div><div style="font-family:arial,sans-serif" class="gmail_default">Because it should be what is most helpful and useful for end-users, not the maintainer.</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">It's a worse experience for the end-user, doesn't actually save the maintainer any time, and really the only benefit is that the port needs fewer changes if the name of the program suddenly changes, which occurs once every never.</div><div style="font-family:arial,sans-serif" class="gmail_default"><br></div><div style="font-family:arial,sans-serif" class="gmail_default">We are not the customer, nor is make(1).</div><br></div><div class="gmail_quote gmail_quote_container"><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr">Adam Weinberger<br><a href="mailto:adamw@adamw.org" target="_blank">adamw@adamw.org</a> // <a href="mailto:adamw@FreeBSD.org" target="_blank">adamw@FreeBSD.org</a></div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwchX7-EajmefbCHWz=%2Bq5tcpbDVw5NNqLWP_ity8TO7%2BdQ>